browser-report
browser-report copied to clipboard
keithws
Extended geo information and typescript definition
You must convince me. I see GeoIP as a feature beyond what a "browser report" should include and also a feature that can easily be provided by a separate module. Also, I've used freegeoip.net in past until their TLS support disappeared. I see it's back now, but I vastly prefer ipify's HTTPS first approach and their unlimited usage policy.
Thank you for your remark. I totally agree that geoip feature is beyond the functionality of the browser-report, but you had included it and I liked and it's very helpful.
And if browser-report contains it, why not do we add useful information for free?
About TLS, I've switched to HTTPS endpoint.
freegeoip vs. ipify 1 0 a lot of additional info 0 1 15K per an hour vs. unlim (for 1 client, this is a client lib, not for a server, IP addresses are different always) 1 1 open source 1 0 open source community is bigger
It would be nice to split out the addition of the TypeScript definitions into a separate PR so that the freegeoip vs. ipify debate does not block the addition of the types.
Thank you for your contributions! This is quite an interesting library.
Note, I have no objects to the TypeScript definitions. Please create a separate PR for that.
I want to stay with ipify, so perhaps a solution here is to make underlying IP service swappable? The Maxmind GeoIP2 service should be pluggable here as well for people that want more data and are willing to pay for it.
Also, note that I plan for this code to become Universal and run on the client and the server. On the server, the remote client IP address should be included in the incoming request, so the server side code path will not make any calls to get the IP address (at least not by default.) Also, calling freegeoip from a single server for all incoming requests may run into limits.