instance-manager icon indicating copy to clipboard operation
instance-manager copied to clipboard

replace os family container arg with cm flag

Open estela-ramirez opened this issue 5 months ago • 1 comments

What type of PR is this?

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Feature/Enhancement (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update
  • [ ] Refactoring (no functional changes)
  • [ ] Performance improvement
  • [ ] Test updates
  • [ ] CI/CD related changes
  • [ ] Dependency upgrade

Description

Related issue(s)

High-level overview of changes

Testing performed

Checklist

  • [ ] I've read the CONTRIBUTING doc
  • [ ] I've added/updated tests that prove my fix is effective or that my feature works
  • [ ] I've added necessary documentation (if appropriate)
  • [ ] I've run make test locally and all tests pass
  • [ ] I've signed-off my commits with git commit -s for DCO verification
  • [ ] I've updated any relevant documentation
  • [ ] Code follows the style guidelines of this project

Additional information

estela-ramirez avatar Jun 23 '25 07:06 estela-ramirez

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.57%. Comparing base (8188aaf) to head (fcfa7f1).

Files with missing lines Patch % Lines
controllers/reconcilers.go 0.00% 7 Missing :warning:
controllers/provisioners/eks/eks.go 78.94% 2 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   46.48%   46.57%   +0.08%     
==========================================
  Files          40       40              
  Lines        7075     7094      +19     
==========================================
+ Hits         3289     3304      +15     
- Misses       3627     3632       +5     
+ Partials      159      158       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 23 '25 07:06 codecov-commenter