Error handling in UI is broken (ErrorComponent and ErrorBoundary)

[talboren]

trafficstars

Describe the bug Error handling in the UI is broken, a simple use case can be when the API is not reachable and we throw the "KeepApiError", the only thing that is shown on the screen is Keep's logo.

To Reproduce Steps to reproduce the behavior:

1. Take down the API
2. Start the UI
3. Go to localhost:3000

Expected behavior Error should be presented beautifully with all the context that is possible and a clear CTA should be displayed (e.g. "Try Again")

Screenshots

[TakshPanchal]

Hey @talboren , I wanted to take this issue. I will look around the code and let you know the solution approach.

[talboren]

Hey @talboren , I wanted to take this issue. I will look around the code and let you know the solution approach.

Perfect @TakshPanchal, thank you! You can reach out to @shahargl who added the ErrorBoundary approach and consult with him.

[shahargl]

hey @TakshPanchal , any progress? want me to dive in?

[Matvey-Kuk]

/bounty 50

[algora-pbc[bot]]

💎 $50 bounty • Keep (YC W23)

Steps to solve:

1. Start working: Comment /attempt #465 with your implementation plan
2. Submit work: Create a pull request including /claim #465 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to keephq/keep!

Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🔴 @ibishal	Jun 6, 2024, 10:35:04 AM	WIP
🔴 @TakshPanchal	Jun 13, 2024, 10:38:09 AM	WIP
🔴 @ezhil56x	Jun 25, 2024, 8:34:52 PM	WIP
🟢 @35C4n0r	Jul 30, 2024, 4:28:18 PM	#1534

[ibishal]

/attempt #465 can i get assigned with it ?

Algora profile	Completed bounties	Tech	Active attempts	Options
@ibishal	2 bounties from 2 projects	Rust, Scala, TypeScript		Cancel attempt

[algora-pbc[bot]]

@ibishal: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then 🙏

[35C4n0r]

@ibishal is there any update from you, are you still working on this one.

[algora-pbc[bot]]

The bounty is up for grabs! Everyone is welcome to /attempt #465 🙌

[TakshPanchal]

/attempt #465

Algora profile	Completed bounties	Tech	Active attempts	Options
@TakshPanchal	1 bounty from 1 project	Jupyter Notebook, JavaScript, Python & more		Cancel attempt

[TakshPanchal]

is it possible to discuss this on a meet @shahargl. I have some findings.

[algora-pbc[bot]]

@TakshPanchal: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then 🙏

[algora-pbc[bot]]

The bounty is up for grabs! Everyone is welcome to /attempt #465 🙌

[ezhil56x]

/attempt #465

Algora profile	Completed bounties	Tech	Active attempts	Options
@ezhil56x	7 keephq bounties + 27 bounties from 10 projects	JavaScript, TypeScript, Java & more	﹟1258	Cancel attempt

[TakshPanchal]

I am able to display error to user using error boundry.

[ezhil56x]

@TakshPanchal Are you still working on this?

[TakshPanchal]

Yes yes, I have created PR too

[algora-pbc[bot]]

@ezhil56x: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then 🙏

[algora-pbc[bot]]

The bounty is up for grabs! Everyone is welcome to /attempt #465 🙌

[35C4n0r]

I don't see any activity, I'm picking this up.

/attempt #465

Algora profile	Completed bounties	Tech	Active attempts	Options
@35C4n0r	14 keephq bounties + 10 bounties from 4 projects	Python, HTML, JavaScript & more		Cancel attempt

[35C4n0r]

[algora-pbc[bot]]

💡 @35C4n0r submitted a pull request that claims the bounty. You can visit your bounty board to reward.

[algora-pbc[bot]]

🎉🎈 @35C4n0r has been awarded $50! 🎈🎊

• Share on socials
• Give feedback