keep
keep copied to clipboard
keephq
feat: Refactoring workflow builder to use React Flow
@Bhavyajain21 is attempting to deploy a commit to the KeepHQ Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Bhavyajain21 all issues that were raised in yesterday's demo are already implemented?
Yes @talboren , we've tried to bring it as close as possible. Please review!
@Bhavyajain21 all issues that were raised in yesterday's demo are already implemented?
@talboren there are some things left. like validations and few things. we might need some time. will update you by EOD
FYI: @Bhavyajain21
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| keep | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 1, 2024 3:34pm |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 30.66%. Comparing base (
6d5c759) to head (6b8648d). Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1488 +/- ##
==========================================
- Coverage 30.68% 30.66% -0.02%
==========================================
Files 54 54
Lines 5028 5031 +3
==========================================
Hits 1543 1543
- Misses 3485 3488 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
There's still a lot of code to be removed (everything related with sequential-workflow-designer)
cc: @Bhavyajain21 @rajeshj11
https://github.com/user-attachments/assets/39131671-b601-41d7-8d4f-f11c2950468d
@Bhavyajain21 can you please check the @talboren comments. I will be available from tomorrow
- toolbox hides error message
- is this mandatory?
poin1 is fixed. point 2 yes it is mandatory
CleanShot.2024-08-25.at.18.18.18.mp4
During the deployment of the preview workflow, an issue was encountered. This has now been resolved. However, if the problem persists, it may be due to the frontend service not being operational. Please verify that the frontend service is running when you are deploying the workflow.
@talboren , the changes are pushed by @rajeshj11 . Can you please review?
@talboren (as discussed in slack) In the toolbox, you'll have 3 new "Triggers" dragable steps It can only go in the beginning and it defines what triggers the workflow has
- We will add a new group to the toolbox. Please suggest a name for this group and the corresponding node names so I can begin working on it.
- Once a node from this group is added, it will be disabled in the toolbox to prevent users from adding duplicate trigger nodes.
- The start node cannot be removed, as it serves as the essential entry point for beginning the development process.
- The initial connection from the start node must always link to one of the three specified nodes; other nodes will not be permitted for this connection. (I need clarification on this point.)
- not sure why it needs to be draggable. (it is doable. still want to know why it is needed)
@Bhavyajain21 @rajeshj11 please note that tests are failing :(
on it
@Bhavyajain21 @rajeshj11 please note that tests are failing :(
now tests are passed. please check
A few comments: Save button is redundant, it made me not understand what's wrong with the workflow until I clicked on it. Triggers: We need validation for workflow saying "No triggers were configured, please configure at least 1 trigger" If I add manual trigger, there is not reason to check the box We need to add some divider for the configuration part If trigger was added, if should be removed from the toolbox (e,.g., it's confusing that I still have manual when it's already in the workflow and I can't do anything with it) Instead of "Trigger end" change to "Workflow start"