keepassxc-browser icon indicating copy to clipboard operation
keepassxc-browser copied to clipboard

Cannot create New entry, after clicking Update (and seeing that no entry is actually correct)

Open stdedos opened this issue 1 year ago • 16 comments

Expected Behavior

Even after clicking "Update" to update an existing entry, the user might want again to create a new entry (because the "correct" entry is not coming up)

Current Behavior

Clicking "Update" is final.

Possible Solution

Steps to Reproduce (for bugs)

Debug info

KeePassXC - 2.7.8 KeePassXC-Browser - 1.9.0.3 Operating system: Win64 Browser: Chrome/Chromium 117.0.0.0

stdedos avatar Jun 02 '24 19:06 stdedos

I'm not 100% sure what you mean here. Could you clarify this a little bit?

varjolintu avatar Jun 03 '24 06:06 varjolintu

Clicking update here

image

and the "for some reason" realizing that there is no suitable account to update, means you are "loosing the possibility" to save the credentials-in-question (either you don't save them, and you log out / log in again to trigger this - or you "update" a wrong entry, and you loose that entry)

stdedos avatar Jun 04 '24 13:06 stdedos

If the Update is not triggered/activated, you won't lose the account if you click the New button, right?

varjolintu avatar Jun 04 '24 14:06 varjolintu

AFAIS New button disappears after clicking Update. In my case, I had multiple entries to consider, and none of them were the correct one.

stdedos avatar Jun 04 '24 14:06 stdedos

You can cancel the update, and you have still both options available.

varjolintu avatar Jun 04 '24 15:06 varjolintu

You can cancel the update, and you have still both options available.

I don't see where you see that 😕

On the current test system, I have two test DBs.

  1. I selected one.
  2. KeepassXC asked me "do I want to update the entry".
  3. I said "Cancel".

I saw this

image

stdedos avatar Jun 04 '24 17:06 stdedos

Seems like a logical result to the question asked and the answer given.

droidmonkey avatar Jun 04 '24 17:06 droidmonkey

Seems like a logical result

Yes. Maybe. idk.

My question/request is that I can change my mind in the Update operation, if it is not yet committed, i.e.:

  1. There is only one credential and I haven't clicked Yes on the "do I want to update the entry" in KeepassXC, or
  2. There are multiple entries, from which I should choose which one to update

stdedos avatar Jun 04 '24 17:06 stdedos

Clicking update here

image

and the "for some reason" realizing that there is no suitable account to update, means you are "loosing the possibility" to save the credentials-in-question (either you don't save them, and you log out / log in again to trigger this - or you "update" a wrong entry, and you loose that entry)

Here

image

There is no New button any more

stdedos avatar Jun 08 '24 12:06 stdedos

But there's the "Dismiss" button and it wil return to the step where both New and Update buttons are shown again.

varjolintu avatar Jun 09 '24 04:06 varjolintu

Dismiss is the same button as in the first version of the pop-up. There, it means "No, I don't want to save that entry".

Neither the color, nor the text is changed. Why would I guess that it is a different action (i.e., back)? Why would I need a back/forward mechanism, when I could've just pressed New again?

stdedos avatar Jun 09 '24 08:06 stdedos

Dismiss lets you decide again. Cancel would cancel the whole process.

varjolintu avatar Jun 09 '24 08:06 varjolintu

Dismiss lets you decide again.

Not really - as here

image

you've already setup that "Dismiss" means "throw away" / "cancel" / "ignore".

"Back" (maybe without a red background) would be a more "natural" option IMHO

stdedos avatar Jun 09 '24 09:06 stdedos

Maybe the button text could be changed to "Back", yes. I still fail to see the original issue here. KeePassXC even verifies from user if the entry is going to be updated.

varjolintu avatar Jun 09 '24 09:06 varjolintu

I just tested it: Dismiss here

image

does get you back to this

image

tl;dr it's a UX issue.

Kindly consider renaming that "Dismiss" button as "Back" on the second state - or any other way you deem appropriate to inform/differentiate the first and the second "Dismiss" buttons.

stdedos avatar Jun 09 '24 09:06 stdedos

Created a PR where buttons are renamed.

varjolintu avatar Jun 09 '24 10:06 varjolintu