keepassxc-browser
keepassxc-browser copied to clipboard
Cannot create New entry, after clicking Update (and seeing that no entry is actually correct)
Expected Behavior
Even after clicking "Update" to update an existing entry, the user might want again to create a new entry (because the "correct" entry is not coming up)
Current Behavior
Clicking "Update" is final.
Possible Solution
Steps to Reproduce (for bugs)
Debug info
KeePassXC - 2.7.8 KeePassXC-Browser - 1.9.0.3 Operating system: Win64 Browser: Chrome/Chromium 117.0.0.0
I'm not 100% sure what you mean here. Could you clarify this a little bit?
Clicking update here
and the "for some reason" realizing that there is no suitable account to update, means you are "loosing the possibility" to save the credentials-in-question (either you don't save them, and you log out / log in again to trigger this - or you "update" a wrong entry, and you loose that entry)
If the Update is not triggered/activated, you won't lose the account if you click the New button, right?
AFAIS New button disappears after clicking Update. In my case, I had multiple entries to consider, and none of them were the correct one.
You can cancel the update, and you have still both options available.
You can cancel the update, and you have still both options available.
I don't see where you see that 😕
On the current test system, I have two test DBs.
- I selected one.
- KeepassXC asked me "do I want to update the entry".
- I said "Cancel".
I saw this
Seems like a logical result to the question asked and the answer given.
Seems like a logical result
Yes. Maybe. idk.
My question/request is that I can change my mind in the Update operation, if it is not yet committed, i.e.:
- There is only one credential and I haven't clicked Yes on the "do I want to update the entry" in KeepassXC, or
- There are multiple entries, from which I should choose which one to update
Clicking update here
and the "for some reason" realizing that there is no suitable account to update, means you are "loosing the possibility" to save the credentials-in-question (either you don't save them, and you log out / log in again to trigger this - or you "update" a wrong entry, and you loose that entry)
Here
There is no New button any more
But there's the "Dismiss" button and it wil return to the step where both New and Update buttons are shown again.
Dismiss is the same button as in the first version of the pop-up. There, it means "No, I don't want to save that entry".
Neither the color, nor the text is changed. Why would I guess that it is a different action (i.e., back)?
Why would I need a back/forward mechanism, when I could've just pressed New again?
Dismiss lets you decide again. Cancel would cancel the whole process.
Dismiss lets you decide again.
Not really - as here
you've already setup that "Dismiss" means "throw away" / "cancel" / "ignore".
"Back" (maybe without a red background) would be a more "natural" option IMHO
Maybe the button text could be changed to "Back", yes. I still fail to see the original issue here. KeePassXC even verifies from user if the entry is going to be updated.
I just tested it: Dismiss here
does get you back to this
tl;dr it's a UX issue.
Kindly consider renaming that "Dismiss" button as "Back" on the second state - or any other way you deem appropriate to inform/differentiate the first and the second "Dismiss" buttons.
Created a PR where buttons are renamed.
