keepassxc-browser icon indicating copy to clipboard operation
keepassxc-browser copied to clipboard

Right to Left Page layout for Hebrew and other rtl languages

Open avma opened this issue 4 years ago • 4 comments

In the Hebrew language (and in other RTL languages) the software screens should be oriented and aligned to the right (sentences are written and read from the right edge of the page and left) hence the expectation that the software screens will behave in the same way i.e right to left direction. Otherwise it is not really possible to read the screens or use the software in Hebrew.

Expected Behaviour

Proper TRL direction, layout and alignment.

Current Behaviour

Hebrew translated screens/dialog are left orientated and aligned

Possible Solution

Add RTL direction to TRL languages with something like

...

Steps to Reproduce (for bugs)

  1. login ln the machine Hebrew
  2. Launch Firefox/Chrome
  3. login the KeePassXC DB
  4. Launch KeePassXC browser

Debug info

KeePassXC - 2.7.0-snapshot KeePassXC-Browser - 1.7.9.1 Operating system: Linux x86_64 Browser: Mozilla Firefox 90.0

avma avatar Jul 25 '21 06:07 avma

We need to put a special substitution in the css: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization#predefined_messages

body {
  direction: __MSG_@@bidi_dir__;
}

div#header {
  margin-bottom: 1.05em;
  overflow: hidden;
  padding-bottom: 1.5em;
  padding-__MSG_@@bidi_start_edge__: 0;
  padding-__MSG_@@bidi_end_edge__: 1.5em;
  position: relative;
}

droidmonkey avatar Jul 25 '21 11:07 droidmonkey

Great, Thanks...

avma avatar Jul 26 '21 05:07 avma

Our options page etc. is not designed for displaying RTL correctly. Support for this needs a bigger makeover.

varjolintu avatar Aug 04 '21 08:08 varjolintu

Bootstrap suggests to include a separate version of RTL Bootstrap to make this possible: https://getbootstrap.com/docs/5.0/getting-started/rtl/

varjolintu avatar Mar 20 '22 09:03 varjolintu