kcp
kcp copied to clipboard
kcp-dev
Figure Out Correct Way To Separate Codegen Tags and GoDoc
For types where these attributes were *also* added to struct tags, having them on separate lines caused an error:
2023/01/11 07:57:40 OpenAPI code generation error: Failed executing generator: some packages had errors:
Tags in comment and struct should match for member (SubResources) of (github.com/kcp-dev/kcp/pkg/apis/apiresource/v1alpha1.CommonAPIResourceSpec)
Why is it correct to do this here?
Originally posted by @stevekuznetsov in https://github.com/kcp-dev/kcp/pull/2105#discussion_r1067410944
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kcp-ci-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.