kcp
kcp copied to clipboard
kcp-dev
bug: It's Possible to Break Our Generated API Resource Schemas
Describe the bug
If you change the Go types and also change the generated APIResourceSchemas to perfectly match what the generator would have created, the result is that the generator won't know that the name of the APIRS needs to be bumped (generated values are equal to previous on-disk values).
Steps To Reproduce
Update a comment on a type. Update the API Resource Schema to have the new comment. Run make codegen and see no changes.
Expected Behaviour
If you change the body of a generated APIRS but not the name, something should fix that for you.
Additional Context
No response
At the very least, we should have CI verify that if a generated APIResourceSchema has diffs, metadata.name is included
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kcp-ci-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.