kcp
kcp copied to clipboard
KCP Server Version gitTreeState shows dirty when run kubectl version
Describe the bug gitTreeState for server version is shown as dirty when kubectl version is run
To Reproduce Steps to reproduce the behavior:
- export kcp kubeconfig
- Run command ‘kubectl version’ [knarra@knarra openshift-tests-private]$ kubectl version Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.0", GitCommit:"45460a55f50834ff18308b13b4569a6c89b9d37a", GitTreeState:"clean", BuildDate:"2022-06-21T19:05:03Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5+kcp-v0.0.0-fccfb61", GitCommit:"fccfb61", GitTreeState:"dirty", BuildDate:"2022-06-03T10:48:20Z", GoVersion:"go1.17.11", Compiler:"gc", Platform:"linux/amd64"}
Expected behavior gitTreeState for kcp server version should not show dirty when kubectl version is run.
Additional context
$ make build
go build -ldflags="-X k8s.io/client-go/pkg/version.gitCommit=eb7bb41e -X k8s.io/client-go/pkg/version.gitTreeState=clean -X k8s.io/client-go/pkg/version.gitVersion=v1.23.5+kcp-v0.5.0-alpha.1-552-geb7bb41e9f713e -X k8s.io/client-go/pkg/version.gitMajor=1 -X k8s.io/client-go/pkg/version.gitMinor=23 -X k8s.io/client-go/pkg/version.buildDate=2022-07-12T15:56:10Z -X k8s.io/component-base/version.gitCommit=eb7bb41e -X k8s.io/component-base/version.gitTreeState=clean -X k8s.io/component-base/version.gitVersion=v1.23.5+kcp-v0.5.0-alpha.1-552-geb7bb41e9f713e -X k8s.io/component-base/version.gitMajor=1 -X k8s.io/component-base/version.gitMinor=23 -X k8s.io/component-base/version.buildDate=2022-07-12T15:56:10Z" ./cmd/...
$ kcp start &
...
$ KUBECONFIG=.kcp/admin.kubeconfig kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:48:33Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5+kcp-v0.5.0-alpha.1-552-geb7bb41e9f713e", GitCommit:"eb7bb41e", GitTreeState:"clean", BuildDate:"2022-07-12T15:56:10Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}
We're building kcp with clean state, kubectl version shows clean state for server. This looks like an issue with your environment?
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kcp-ci-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.