ember-cli-code-coverage icon indicating copy to clipboard operation
ember-cli-code-coverage copied to clipboard

Published 20 hours ago • verified publisher icon kategengler

Add include option to add additional coverage to the report

Open jesseditson opened this issue 8 years ago • 2 comments

This PR adds an include option to the config hash that will allow users to include additional coverage to the output.

My current setup is as follows:

  • I have application server code that lives in server
  • I have a suite of tests for app server code that lives in test
  • I run server tests on rebuild using an in-repo addon
  • The server tests output to coverage-server, which I'd like to include in the coverage report

This option allows me to specify the coverage-server/coverage-final.json (generated via nyc), and get accurate coverage on my entire app, instead of having 2 different coverage reports.

jesseditson avatar Nov 23 '16 17:11 jesseditson

Relates to: https://github.com/ember-cli/rfcs/issues/81 - with that RFC and this PR, tests & coverage would work across both the app and the server code

jesseditson avatar Nov 23 '16 18:11 jesseditson

This seems okay to me. @rwjblue @kategengler @kellyselden thoughts? I would definitely like to see some tests added here, but I am not opposed to the idea of this feature.

RobbieTheWagner avatar Sep 30 '17 13:09 RobbieTheWagner