karmada icon indicating copy to clipboard operation
karmada copied to clipboard

changed the healthz and metric server port of the descheduler to different ports than scheduler to avoid flaky test failures

Open zclyne opened this issue 5 months ago • 3 comments

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

It changes the metrics and healthz server port of the descheduler to different ports than the scheduler's unit test to avoid flaky test failures.

Which issue(s) this PR fixes: Fixes #6441

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

zclyne avatar Jun 13 '25 23:06 zclyne

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 45.35%. Comparing base (9824e3d) to head (a129087). Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/testing/helpers.go 0.00% 24 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6454      +/-   ##
==========================================
- Coverage   45.36%   45.35%   -0.02%     
==========================================
  Files         687      687              
  Lines       56358    56382      +24     
==========================================
+ Hits        25567    25572       +5     
- Misses      29194    29215      +21     
+ Partials     1597     1595       -2     
Flag Coverage Δ
unittests 45.35% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 14 '25 00:06 codecov-commenter

It's strange. Why is port 8084 occupied?

I'm also a bit confused why setting to 8084 and 8085 would fail but 8085 and 8086 succeeds, but I haven't got time to look into it yet. Will continue investigating it

zclyne avatar Jun 18 '25 00:06 zclyne

cc @XiShanYongYe-Chang

RainbowMango avatar Jul 21 '25 01:07 RainbowMango

@zclyne Thanks the changes looks really good. I have just two nits otherwise it LGTM 💪:

  • Squashing git commits into one to be ready for potential merging
  • Moving the PR out of the draft mode to signal to reviewers it is ready for review

Thanks for reviewing. I have marked this PR ready for review and will squash the commits as suggested.

zclyne avatar Jul 22 '25 02:07 zclyne

/gemini-review

XiShanYongYe-Chang avatar Jul 23 '25 01:07 XiShanYongYe-Chang

Acknowledged. I am initiating a comprehensive code review for this pull request as requested. Please allow some time for the review to be completed and posted.

gemini-code-assist[bot] avatar Jul 23 '25 01:07 gemini-code-assist[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohamedawnallah, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jul 23 '25 01:07 karmada-bot