karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Add e2e for cluster status condition collecting

Open XiShanYongYe-Chang opened this issue 6 months ago • 3 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The cluster-status-controller collects cluster status changes and reflects the status in the Condition whose type is Ready. This pr add the e2e for this case.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

XiShanYongYe-Chang avatar Jun 04 '25 02:06 XiShanYongYe-Chang

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jun 04 '25 02:06 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.03%. Comparing base (bd5692f) to head (c26a426).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6427      +/-   ##
==========================================
- Coverage   49.05%   49.03%   -0.02%     
==========================================
  Files         687      687              
  Lines       56061    56061              
==========================================
- Hits        27500    27492       -8     
- Misses      26780    26786       +6     
- Partials     1781     1783       +2     
Flag Coverage Δ
unittests 49.03% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 04 '25 03:06 codecov-commenter

/cc @RainbowMango

XiShanYongYe-Chang avatar Jun 04 '25 03:06 XiShanYongYe-Chang

/cc @RainbowMango

XiShanYongYe-Chang avatar Jun 26 '25 08:06 XiShanYongYe-Chang

/cc @RainbowMango

XiShanYongYe-Chang avatar Sep 28 '25 09:09 XiShanYongYe-Chang