Deprecated Immediately and Graciously PurgeMode

[XiShanYongYe-Chang]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Deprecated Immediately and Graciously PurgeMode, and

• Treat 'Immediately' as 'Directly'
• Treat 'Graciously' as 'Gracefully'

Which issue(s) this PR fixes: Part of #6317

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

API Change: deprecated Immediately and Graciously PurgeMode

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.35%. Comparing base (5f4bd5e) to head (c3e5b1d).

Files with missing lines	Patch %	Lines
pkg/controllers/binding/common.go	0.00%	4 Missing :warning:
pkg/controllers/cluster/taint_manager.go	50.00%	4 Missing :warning:
pkg/controllers/applicationfailover/common.go	50.00%	1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6387      +/-   ##
==========================================
- Coverage   45.35%   45.35%   -0.01%     
==========================================
  Files         687      687              
  Lines       56384    56397      +13     
==========================================
+ Hits        25572    25577       +5     
- Misses      29217    29224       +7     
- Partials     1595     1596       +1     

Flag	Coverage Δ
unittests	45.35% <72.72%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[XiShanYongYe-Chang]

/retest

[XiShanYongYe-Chang]

/cc @RainbowMango

[XiShanYongYe-Chang]

  [FAILED] Unexpected error:
      <*fmt.wrapError | 0xc000a1a0c0>: 
      client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline
      {
          msg: "client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline",
          err: <*errors.errorString | 0xc000800030>{
              s: "rate: Wait(n=1) would exceed context deadline",
          },
      }
  occurred
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/suites/base/resourceinterpreter_test.go:538 @ 07/21/25 12:58:56.483

  Full Stack Trace
    github.com/karmada-io/karmada/test/e2e/suites/base.init.func51.10.3.6()
    	/home/runner/work/karmada/karmada/test/e2e/suites/base/resourceinterpreter_test.go:538 +0xb6
    github.com/karmada-io/karmada/test/e2e/suites/base.init.func51.10.3()
    	/home/runner/work/karmada/karmada/test/e2e/suites/base/resourceinterpreter_test.go:516 +0xc36

[XiShanYongYe-Chang]

/retest

[XiShanYongYe-Chang]

/retest

[RainbowMango]

/gemini-review

[gemini-code-assist[bot]]

Thank you for invoking /gemini-review! I am now performing a comprehensive code review of this pull request. I will post my findings and suggestions as review comments on the relevant code changes shortly. Please keep an eye on the "Files changed" tab for the detailed review.

[XiShanYongYe-Chang]

/gemini-review

[gemini-code-assist[bot]]

Thank you for re-invoking /gemini-review. I am processing your request and will post my findings and suggestions as review comments on the relevant code changes in the "Files changed" tab shortly. Please bear with me as I complete the comprehensive review.

[RainbowMango]

Lint failed.

[XiShanYongYe-Chang]

Hi @mszacillo, I plan to start coding on #6593, but it's currently blocked by this pr, could you please review the pr? /cc @mszacillo

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [RainbowMango]
• ~~pkg/apis/OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[mszacillo]

@XiShanYongYe-Chang @RainbowMango Ah apologies! I had taken a look but didn't post my comment. Looked good to me - Directly should more or less function the same way as Immediately though right? We'd just need to pick up the new name in our propagation policies.

[XiShanYongYe-Chang]

Ah apologies! It's okay, don't worry too much about it.

It's okay, don't worry too much about it.

Directly should more or less function the same way as Immediately though right? We'd just need to pick up the new name in our propagation policies.

Yes, we plan to use Directly instead of Immediately and Gracefully instead of Graciously. But for Application Failover, Directly and Graciously will be supported in the current v1alpha1 version of PropagationPolicy.

By the way, we are about to start the development of this feature, and it is expected to be included in this version. We look forward to your feedback on its usage: #6593