karmada
karmada copied to clipboard
karmada-io
fix(detector): fix pp and rb inconsistent
What type of PR is this?
What this PR does / why we need it:
When continuously updating the ·spec.suspension.dispatching· field of pp, the field of rb may be inconsistent with pp.
Which issue(s) this PR fixes: fixes https://github.com/karmada-io/karmada/issues/6379
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 65.85366% with 28 lines in your changes missing coverage. Please review.
Project coverage is 48.55%. Comparing base (
c31c8e4) to head (38b8e12). Report is 10 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/detector/detector.go | 63.15% | 21 Missing and 7 partials :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #6322 +/- ##
==========================================
+ Coverage 48.44% 48.55% +0.10%
==========================================
Files 677 677
Lines 56067 56138 +71
==========================================
+ Hits 27164 27257 +93
+ Misses 27123 27096 -27
- Partials 1780 1785 +5
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 48.55% <65.85%> (+0.10%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
If I remember correctly, we haven't worked out an ideal solution yet, right? How about talk about it at next community meeting?
talk about it at next community meeting?
We will discuss this issue at our next community meeting.
Is this the complete solution for https://github.com/karmada-io/karmada/issues/5996?
No, this PR is only to solve the third case