karmada
karmada copied to clipboard
karmada-io
Handle preserveResourceOnDeletion with dependencise distributor
What type of PR is this?
/kind feature
What this PR does / why we need it:
When users enable dependency distribution for a resource template, if the dependency distributed resources do not have their own propagation policy, they will inherit the PreserveResourcesOnDeletion policy from the resource they are following.
Which issue(s) this PR fixes: Part of #5577
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
`karmada-controller-manager`: handle preserveResourceOnDeletion with dependencise distributor
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: CharlesQQ.
Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @CharlesQQ @RainbowMango
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.53%. Comparing base (
13df63f) to head (f63c134).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5717 +/- ##
=======================================
Coverage 40.52% 40.53%
=======================================
Files 650 650
Lines 55184 55187 +3
=======================================
+ Hits 22365 22369 +4
+ Misses 31386 31385 -1
Partials 1433 1433
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 40.53% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment