karmada icon indicating copy to clipboard operation
karmada copied to clipboard

operator/pkg/tasks/init: unit test karmada resource

Open mohamedawnallah opened this issue 1 year ago • 3 comments

Description

In this commit, we unit test karmada resource init task on running karmada resources, system namespaces, crds, webhook configurations, and api service.

What type of PR is this?

Which issue(s) this PR fixes: Part of #5491.

Does this PR introduce a user-facing change?:

NONE

mohamedawnallah avatar Oct 16 '24 16:10 mohamedawnallah

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (0d55ead) to head (6630227).

Files with missing lines Patch % Lines
operator/pkg/tasks/init/karmadaresource.go 18.18% 9 Missing :warning:
operator/pkg/util/util.go 0.00% 3 Missing :warning:
operator/pkg/util/apiclient/idempotency.go 0.00% 2 Missing :warning:
operator/pkg/util/apiclient/wait.go 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5701      +/-   ##
==========================================
- Coverage   39.09%   38.72%   -0.38%     
==========================================
  Files         650      650              
  Lines       45209    55132    +9923     
==========================================
+ Hits        17676    21350    +3674     
- Misses      26180    32413    +6233     
- Partials     1353     1369      +16     
Flag Coverage Δ
unittests 38.72% <16.66%> (-0.38%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 16 '24 16:10 codecov-commenter

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 17 '24 14:10 karmada-bot

cc @XiShanYongYe-Chang All unit test cases & linting issues passed after rebasing on the master branch :)

mohamedawnallah avatar Oct 17 '24 17:10 mohamedawnallah