karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[Proposal] Support for resource scheduling suspend and resume capabilities

Open Vacant2333 opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind design /kind documentation

Which issue(s) this PR fixes: Fixes https://github.com/karmada-io/karmada/issues/4937

Special notes for your reviewer: Previous Proposal: https://github.com/karmada-io/karmada/pull/5118

Does this PR introduce a user-facing change?:

NONE

Vacant2333 avatar Oct 13 '24 20:10 Vacant2333

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.40%. Comparing base (ba1e68d) to head (2fdd66a). Report is 3 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5690      +/-   ##
==========================================
+ Coverage   48.37%   48.40%   +0.03%     
==========================================
  Files         665      665              
  Lines       54795    54850      +55     
==========================================
+ Hits        26507    26552      +45     
- Misses      26569    26584      +15     
+ Partials     1719     1714       -5     
Flag Coverage Δ
unittests 48.40% <ø> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 13 '24 20:10 codecov-commenter

Should also add rb status condition just like https://github.com/karmada-io/karmada/pull/5317.

Monokaix avatar Nov 28 '24 01:11 Monokaix

/assign

Monokaix avatar Dec 09 '24 07:12 Monokaix

Generally looks good to me. But, would you like to squash the commits?

done

Monokaix avatar Jan 02 '25 02:01 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jan 02 '25 03:01 karmada-bot

/reopen

Monokaix avatar Jan 02 '25 06:01 Monokaix

@Monokaix: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Jan 02 '25 06:01 karmada-bot

/reopen

RainbowMango avatar Jan 02 '25 06:01 RainbowMango

@RainbowMango: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Jan 02 '25 06:01 karmada-bot