karmada icon indicating copy to clipboard operation
karmada copied to clipboard

refactor ensure work

Open XiShanYongYe-Chang opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The ensureWork function has some load, and its complexity will continue to increase during ongoing iterations. Therefore, some refactoring has been done on this function.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

XiShanYongYe-Chang avatar Oct 10 '24 07:10 XiShanYongYe-Chang

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 10 '24 07:10 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 34.34343% with 65 lines in your changes missing coverage. Please review.

Project coverage is 35.86%. Comparing base (5692e28) to head (8413ed6). Report is 415 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controllers/binding/common.go 35.95% 55 Missing and 2 partials :warning:
pkg/controllers/binding/binding_controller.go 20.00% 4 Missing :warning:
...ers/binding/cluster_resource_binding_controller.go 20.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5660      +/-   ##
==========================================
- Coverage   35.91%   35.86%   -0.05%     
==========================================
  Files         648      648              
  Lines       45079    45095      +16     
==========================================
- Hits        16189    16174      -15     
- Misses      27645    27675      +30     
- Partials     1245     1246       +1     
Flag Coverage Δ
unittests 35.86% <34.34%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 10 '24 07:10 codecov-commenter

/cc @RainbowMango

XiShanYongYe-Chang avatar Oct 10 '24 08:10 XiShanYongYe-Chang

OK. will do.

RainbowMango avatar Oct 10 '24 09:10 RainbowMango

/close

XiShanYongYe-Chang avatar Mar 28 '25 08:03 XiShanYongYe-Chang

@XiShanYongYe-Chang: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Mar 28 '25 08:03 karmada-bot