karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Update resource estimator APIs for Priority & Preemption

Open LeonZh0u opened this issue 1 year ago • 2 comments

What type of PR is this?

What this PR does / why we need it: Add Preemption Request and Response in Karmada estimator pb To support priority & preemption in Karmada, resource estimators should inform the scheduler about which resource bindings/workloads to preempt. New types of request and response schemas need to be defined. Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: Priority&Preemption proposal

Does this PR introduce a user-facing change?:

NONE

LeonZh0u avatar Oct 07 '24 17:10 LeonZh0u

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 07 '24 17:10 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 35.18%. Comparing base (62ae95e) to head (20fcd67).

Files with missing lines Patch % Lines
pkg/estimator/service/mock_EstimatorClient.go 0.00% 20 Missing :warning:
pkg/estimator/service/service.pb.go 0.00% 20 Missing :warning:
pkg/estimator/server/server.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5651      +/-   ##
==========================================
- Coverage   35.21%   35.18%   -0.03%     
==========================================
  Files         645      645              
  Lines       44885    44927      +42     
==========================================
+ Hits        15806    15808       +2     
- Misses      27847    27888      +41     
+ Partials     1232     1231       -1     
Flag Coverage Δ
unittests 35.18% <0.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 07 '24 18:10 codecov-commenter