karmada icon indicating copy to clipboard operation
karmada copied to clipboard

operator/pkg/tasks/init: unit test namespace

Open mohamedawnallah opened this issue 1 year ago • 3 comments

Description

In this commit, we unit test the namespace init task in the operator package making sure namespace is created successfully.

What type of PR is this?

Which issue(s) this PR fixes: Part of #5491.

Dependency This PR depends on #5630.

Does this PR introduce a user-facing change?:

NONE

mohamedawnallah avatar Oct 02 '24 03:10 mohamedawnallah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign poor12 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 02 '24 03:10 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.12%. Comparing base (0d55ead) to head (5598567).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5635      +/-   ##
==========================================
+ Coverage   39.09%   39.12%   +0.02%     
==========================================
  Files         650      650              
  Lines       45209    45209              
==========================================
+ Hits        17676    17689      +13     
+ Misses      26180    26164      -16     
- Partials     1353     1356       +3     
Flag Coverage Δ
unittests 39.12% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 17 '24 15:10 codecov-commenter

cc @XiShanYongYe-Chang All unit test cases & linting issues passed after rebasing on the master branch :)

mohamedawnallah avatar Oct 17 '24 16:10 mohamedawnallah