karmada
karmada copied to clipboard
Added tests for pkg/detector
Description: This PR enhances the unit tests for the Resource Detector in the detector package. The improvements aim to increase code reliability, maintainability, and test coverage for the Resource Detector. This PR introduces comprehensive unit tests for various functions in the Resource Detector, including:
- GVRDisabled and NeedLeaderElection
- EventFilter
- OnAdd, OnUpdate, OnDelete
- LookForMatchedPolicy and LookForMatchedClusterPolicy
- ApplyPolicy and ApplyClusterPolicy
- ClaimPolicyForObject and ClaimClusterPolicyForObject
- BuildResourceBinding and BuildClusterResourceBinding
- isWaiting, AddWaiting and RemoveWaiting
- Handling of PropagationPolicy and ClusterPropagationPolicy events
- Cleanup operations for ResourceBinding and ClusterResourceBinding
Additions and Modifications:
- pkg/detector/detector_test.go
Test Coverage:
- detector_test.go: Significant increase in coverage from 1.62% to 50.80%
Overall coverage of detector package: 19.58% to 50.00%
What type of PR is this? /kind feature
Which issue(s) this PR fixes: Fixes a part of #5470
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 35.92%. Comparing base (
8cc712f) to head (2d343b6).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5631 +/- ##
==========================================
+ Coverage 35.19% 35.92% +0.73%
==========================================
Files 645 645
Lines 44869 44869
==========================================
+ Hits 15791 16121 +330
+ Misses 27846 27448 -398
- Partials 1232 1300 +68
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 35.92% <ø> (+0.73%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/assign
Tracked by #5711 and #5746