karmada icon indicating copy to clipboard operation
karmada copied to clipboard

docs: add proposal of karmadactl init images list

Open tiansuo114 opened this issue 1 year ago • 6 comments

What type of PR is this? /kind feature

What this PR does / why we need it: karmadactl supports list init images Which issue(s) this PR fixes: Parts of #4086

Special notes for your reviewer: @liangyuanpeng
@RainbowMango This pr is about this question in #5277,we can solve the design problems related to the karmadactl config image list in this pr

Does this PR introduce a user-facing change?:


tiansuo114 avatar Sep 28 '24 07:09 tiansuo114

Hi, this is a bot comment, just put the label of ok-to-test here, you can comment /retest to rerun github workflow if github workflow is failing and it's not releated with this PR.

/ok-to-test

liangyuanpeng avatar Sep 28 '24 07:09 liangyuanpeng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 28 '24 07:09 karmada-bot

I have already modified this document according to the discussion requirements from the meeting. When you have time, please kindly review it. @liangyuanpeng @RainbowMango

tiansuo114 avatar Oct 01 '24 02:10 tiansuo114

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.19%. Comparing base (58612d3) to head (47866ec). Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5623      +/-   ##
==========================================
- Coverage   35.20%   35.19%   -0.01%     
==========================================
  Files         645      645              
  Lines       44869    44869              
==========================================
- Hits        15795    15792       -3     
- Misses      27844    27845       +1     
- Partials     1230     1232       +2     
Flag Coverage Δ
unittests 35.19% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 01 '24 02:10 codecov-commenter

Our stance regarding the addition of related features corresponding to this document is: should they be retained or removed? I estimate that if we adhere to the content in this document, the code for the newly added related functionality will be around 100-200 lines. @RainbowMango @liangyuanpeng

tiansuo114 avatar Oct 08 '24 06:10 tiansuo114

let's pause this session based on the content of the meeting

/hold

liangyuanpeng avatar Oct 13 '24 14:10 liangyuanpeng

Based on community meetings, it seems that this feature is not necessary and will increase maintenance costs, so this pr is temporarily closed

tiansuo114 avatar Oct 24 '24 00:10 tiansuo114