karmada
karmada copied to clipboard
karmada-io
Implement base group score calc to assign replicas evenly
What type of PR is this? /kind feature
What this PR does / why we need it: Optimize the score calculation method to better measure the pros and cons of the group. This PR implements base group score calc to assign replicas evenly.
Which issue(s) this PR fixes: Fixes #4805
Special notes for your reviewer: @whitewindmills
Does this PR introduce a user-facing change?:
`karmada-scheduler`: implement group score calculation instead of take the highest score of clusters
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 84.48276% with 9 lines in your changes missing coverage. Please review.
Project coverage is 41.68%. Comparing base (
58612d3) to head (aa8cbda). Report is 176 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../scheduler/core/spreadconstraint/group_clusters.go | 84.48% | 7 Missing and 2 partials :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5621 +/- ##
==========================================
+ Coverage 35.20% 41.68% +6.48%
==========================================
Files 645 653 +8
Lines 44869 55533 +10664
==========================================
+ Hits 15795 23149 +7354
- Misses 27844 30883 +3039
- Partials 1230 1501 +271
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.68% <84.48%> (+6.48%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: whitewindmills
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [whitewindmills]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@ipsum-0320 Are you going to squash the commits? https://karmada.io/docs/contributor/github-workflow/#squash-commits
@ipsum-0320 Are you going to squash the commits? https://karmada.io/docs/contributor/github-workflow/#squash-commits
@RainbowMango yeah, i will compress these commits now.
@ipsum-0320 Are you going to squash the commits? https://karmada.io/docs/contributor/github-workflow/#squash-commits
now, i have squashed the commits. @RainbowMango
I have resolved the issues you raised; please review it once again. @RainbowMango