karmada
karmada copied to clipboard
karmada-io
Add unit test for group score calc to assign replicas evenly
What type of PR is this? /kind feature
What this PR does / why we need it: Optimize the score calculation method to better measure the pros and cons of the group. This PR added unit test for group score calc to assign replicas evenly.
Which issue(s) this PR fixes: Fixes #4805
Special notes for your reviewer: @whitewindmills
Does this PR introduce a user-facing change?:
`karmada-scheduler`: implement group score calculation instead of take the highest score of clusters
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
master@5432d32). Learn more about missing BASE report. Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5620 +/- ##
=========================================
Coverage ? 41.61%
=========================================
Files ? 655
Lines ? 55753
Branches ? 0
=========================================
Hits ? 23200
Misses ? 31044
Partials ? 1509
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.61% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
