karmada icon indicating copy to clipboard operation
karmada copied to clipboard

operator/pkg: unit test init and deinit

Open mohamedawnallah opened this issue 1 year ago • 2 comments

Description

In this commit, we unit test the init and deinit workflows in the operator pkg.

What type of PR is this?

Which issue(s) this PR fixes: Part of #5491.

Dependency: This PR depends on #5616, #5617, and #5630.

Does this PR introduce a user-facing change?:

NONE

mohamedawnallah avatar Sep 26 '24 13:09 mohamedawnallah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 26 '24 13:09 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (4c8bcd4) to head (1760599). Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/test_helper.go 46.66% 10 Missing and 6 partials :warning:
operator/pkg/controller/karmada/planner.go 0.00% 2 Missing :warning:
operator/pkg/init.go 85.71% 1 Missing and 1 partial :warning:
operator/pkg/util/kubeconfig.go 0.00% 2 Missing :warning:
operator/pkg/deinit.go 85.71% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
+ Coverage   34.14%   36.36%   +2.21%     
==========================================
  Files         643      646       +3     
  Lines       44524    44891     +367     
==========================================
+ Hits        15203    16323    +1120     
+ Misses      28165    27302     -863     
- Partials     1156     1266     +110     
Flag Coverage Δ
unittests 36.36% <58.18%> (+2.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 26 '24 21:09 codecov-commenter