karmada icon indicating copy to clipboard operation
karmada copied to clipboard

add events for ResourceInterpreter

Open whitewindmills opened this issue 1 year ago • 3 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

whitewindmills avatar Sep 13 '24 10:09 whitewindmills

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 13 '24 10:09 karmada-bot

/cc @RainbowMango

whitewindmills avatar Sep 13 '24 10:09 whitewindmills

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (dc36986) to head (3dd93ec). Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
pkg/detector/detector.go 0.00% 4 Missing :warning:
pkg/controllers/status/common.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5541      +/-   ##
==========================================
+ Coverage   33.86%   34.13%   +0.26%     
==========================================
  Files         643      643              
  Lines       44500    44512      +12     
==========================================
+ Hits        15072    15196     +124     
+ Misses      28280    28159     -121     
- Partials     1148     1157       +9     
Flag Coverage Δ
unittests 34.13% <0.00%> (+0.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 13 '24 11:09 codecov-commenter