karmada
karmada copied to clipboard
pkg/webhook: refactor Multi-Cluster Service test
Description
In this commit, we refactor the multi-cluster service object names and check on number of patches after the mutation happens.
Motivation and Context
Motivated by @XiShanYongYe-Chang's comment https://github.com/karmada-io/karmada/pull/5494#discussion_r1758148145.
What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes: Follow-up on #5517.
Does this PR introduce a user-facing change?:
NONE
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.16%. Comparing base (
87ee756) to head (1467cea). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5539 +/- ##
==========================================
+ Coverage 48.13% 48.16% +0.02%
==========================================
Files 677 677
Lines 56068 56067 -1
==========================================
+ Hits 26991 27002 +11
+ Misses 27305 27296 -9
+ Partials 1772 1769 -3
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 48.16% <ø> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
I think this PR is now ready for review after rebasing on the master branch. Thanks!
cc: @XiShanYongYe-Chang
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [XiShanYongYe-Chang]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment