karmada
karmada copied to clipboard
External `etcd` Support for Karmada Operator
What type of PR is this?
/kind feature
What this PR does / why we need it: This is an implementation of this proposal for adding support to the Karmada operator for external etcd cluster connections.
Which issue(s) this PR fixes: Fixes #5242
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
The new `SecretRef` field added as part of the configuration for connecting to an external etcd cluster can be
used to reference a secret that contains credentials for connecting to an external etcd cluster.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign poor12, rainbowmango for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hey @RainbowMango . This is still a work in progress, but I'd really appreciate some early feedback from you and the team to ensure we're well aligned on the way forward for the implementation of this feature.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 124 lines in your changes missing coverage. Please review.
Project coverage is 34.80%. Comparing base (
4c8bcd4) to head (b36b3d8). Report is 40 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5536 +/- ##
==========================================
+ Coverage 34.14% 34.80% +0.66%
==========================================
Files 643 646 +3
Lines 44524 44915 +391
==========================================
+ Hits 15203 15634 +431
+ Misses 28165 28074 -91
- Partials 1156 1207 +51
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 34.80% <0.00%> (+0.66%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@RainbowMango , any thoughts?
Hi @jabellard, As discussed at the community meeting, we will have an alpha release for feature #5478. And here it is: https://github.com/karmada-io/karmada/releases/tag/v1.12.0-alpha.1
And here it is: https://github.com/karmada-io/karmada/releases/tag/v1.12.0-alpha.1
Thank you!
@jabellard, please confirm whether we still need this PR.
@jabellard, please confirm whether we still need this PR.
No longer needed. The other PRs covered the work initially introduced here.