karmada
karmada copied to clipboard
standardize the naming of karmada secrets in karmadactl method
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.
This PR aims to standardize the naming of karmada secrets in karmadactl installation method.
Which issue(s) this PR fixes:
Fixes part of #5363
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
karmadactl: standardize the naming of karmada secrets in karmadactl installation method
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 71.79487% with 22 lines in your changes missing coverage. Please review.
Project coverage is 34.19%. Comparing base (
ef7d528) to head (01eb85b).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5524 +/- ##
==========================================
+ Coverage 34.15% 34.19% +0.03%
==========================================
Files 643 643
Lines 44503 44525 +22
==========================================
+ Hits 15201 15225 +24
+ Misses 28145 28144 -1
+ Partials 1157 1156 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 34.19% <71.79%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.