karmada icon indicating copy to clipboard operation
karmada copied to clipboard

hack/deploy-scheduler-estimator.sh support deploy estimator in the specified namespace

Open zhzhuang-zju opened this issue 1 year ago • 6 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Currently, the karmada-operator does not provide the capability to install the estimator, so it is often combined with hack/deploy-scheduler-estimator.sh to deploy karmada-scheduler-estimator. However, to better align hack/deploy-scheduler-estimator.sh with the installation method of the karmada-operator, we need to:

  • support deploy estimator in the specified namespace
  • GRPC certificate names can be configured to meet the needs of users who want to customize their certificate names.

Additionally, split the parameter MEMBER_CLUSTER_NAME into MEMBER_CLUSTER_CONTEXT and MEMBER_CLUSTER_NAME. Sometimes these two values are different and need to be distinguished.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

  • The new parameter is an optional parameter, and the default value remains unchanged
  • local test
  1. deploy karmada instance in test namespace
  2. join member cluster member1 with cluster context member1-host
  3. hack/deploy-scheduler-estimator.sh ~/.kube/karmada.config karmada-host ~/.kube/member1.config member1-host member1 test karmada-demo-cert
I0909 11:49:10.013859       1 cache.go:111] Start dialing estimator server(karmada-scheduler-estimator-member1.test.svc.cluster.local:10352) of cluster(member1).
I0909 11:49:10.044687       1 cache.go:119] Connection with estimator server(karmada-scheduler-estimator-member1.test.svc.cluster.local:10352) of cluster(member1) has been established.

Does this PR introduce a user-facing change?:


zhzhuang-zju avatar Sep 10 '24 02:09 zhzhuang-zju

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 10 '24 02:09 karmada-bot

cc @jabellard

zhzhuang-zju avatar Sep 10 '24 02:09 zhzhuang-zju

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.57%. Comparing base (6e41d9b) to head (14a8286).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5511   +/-   ##
=======================================
  Coverage   36.56%   36.57%           
=======================================
  Files         648      648           
  Lines       45079    45079           
=======================================
+ Hits        16485    16488    +3     
+ Misses      27351    27348    -3     
  Partials     1243     1243           
Flag Coverage Δ
unittests 36.57% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 10 '24 02:09 codecov-commenter

cc @chaosi-zju

zhzhuang-zju avatar Sep 12 '24 07:09 zhzhuang-zju

All the review comments have been addressed. Do you have any other comments? cc @liangyuanpeng @chaosi-zju

zhzhuang-zju avatar Oct 12 '24 07:10 zhzhuang-zju

generally ok, see what other people think

chaosi-zju avatar Oct 12 '24 08:10 chaosi-zju