karmada icon indicating copy to clipboard operation
karmada copied to clipboard

add test for pkg/controllers/cluster

Open xovoxy opened this issue 1 year ago • 2 comments

What type of PR is this? /kind failing-test

What this PR does / why we need it: add some test for /pkg/controllers/cluster, improve test coverage to 60 above Which issue(s) this PR fixes: Parts of #https://github.com/karmada-io/karmada/issues/5235

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

xovoxy avatar Aug 30 '24 10:08 xovoxy

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.33%. Comparing base (136e268) to head (503fb93). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5467      +/-   ##
==========================================
+ Coverage   31.70%   32.33%   +0.62%     
==========================================
  Files         643      643              
  Lines       44444    44445       +1     
==========================================
+ Hits        14093    14371     +278     
+ Misses      29322    28983     -339     
- Partials     1029     1091      +62     
Flag Coverage Δ
unittests 32.33% <ø> (+0.62%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 30 '24 10:08 codecov-commenter

/lgtm

anujagrawal699 avatar Aug 31 '24 03:08 anujagrawal699

@anujagrawal699: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Aug 31 '24 03:08 karmada-bot

hi @XiShanYongYe-Chang, i have made some changes based on your comment. please check it~

xovoxy avatar Sep 04 '24 00:09 xovoxy

Thanks @xovoxy /assign

XiShanYongYe-Chang avatar Sep 04 '24 01:09 XiShanYongYe-Chang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 09 '24 12:09 karmada-bot