karmada icon indicating copy to clipboard operation
karmada copied to clipboard

feat: make cert validity configurable when install

Open irwin9204 opened this issue 1 year ago • 4 comments

What type of PR is this? /kind feature

What this PR does / why we need it: When install karmada control plane using script or operator, users can configure certificate expiry time.

Which issue(s) this PR fixes: Part of https://github.com/karmada-io/karmada/issues/4787

irwin9204 avatar Aug 27 '24 23:08 irwin9204

Welcome @irwin9204! It looks like this is your first PR to karmada-io/karmada 🎉

karmada-bot avatar Aug 27 '24 23:08 karmada-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng, poor12, rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 28 '24 00:08 karmada-bot

@irwin9204 You might need to sign the DCO per the guideline: https://github.com/karmada-io/karmada/pull/5439/checks?check_run_id=29338981265

RainbowMango avatar Aug 28 '24 02:08 RainbowMango

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 31.13%. Comparing base (a184b40) to head (effc41c). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/init.go 0.00% 15 Missing :warning:
operator/pkg/tasks/init/cert.go 0.00% 11 Missing :warning:
operator/pkg/apis/operator/v1alpha1/defaults.go 0.00% 9 Missing :warning:
operator/pkg/certs/certs.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5439      +/-   ##
==========================================
+ Coverage   30.85%   31.13%   +0.27%     
==========================================
  Files         640      640              
  Lines       44384    44446      +62     
==========================================
+ Hits        13695    13837     +142     
+ Misses      29709    29609     -100     
- Partials      980     1000      +20     
Flag Coverage Δ
unittests 31.13% <0.00%> (+0.27%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 28 '24 02:08 codecov-commenter