karmada
karmada copied to clipboard
feat: make cert validity configurable when install
What type of PR is this? /kind feature
What this PR does / why we need it: When install karmada control plane using script or operator, users can configure certificate expiry time.
Which issue(s) this PR fixes: Part of https://github.com/karmada-io/karmada/issues/4787
Welcome @irwin9204! It looks like this is your first PR to karmada-io/karmada 🎉
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng, poor12, rainbowmango for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@irwin9204 You might need to sign the DCO per the guideline: https://github.com/karmada-io/karmada/pull/5439/checks?check_run_id=29338981265
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
Project coverage is 31.13%. Comparing base (
a184b40) to head (effc41c). Report is 14 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5439 +/- ##
==========================================
+ Coverage 30.85% 31.13% +0.27%
==========================================
Files 640 640
Lines 44384 44446 +62
==========================================
+ Hits 13695 13837 +142
+ Misses 29709 29609 -100
- Partials 980 1000 +20
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 31.13% <0.00%> (+0.27%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.