karmada
karmada copied to clipboard
standardize the naming of karmada secrets in local up method
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.
This PR aims to standardize the naming of karmada secrets in local up installation method.
please refer to #5364
Which issue(s) this PR fixes:
Fixes part of #5363
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
standardize the naming of karmada secrets in local up installation method
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.74%. Comparing base (
840300b) to head (edb224d). Report is 43 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5423 +/- ##
==========================================
+ Coverage 38.59% 39.74% +1.15%
==========================================
Files 649 650 +1
Lines 45133 55131 +9998
==========================================
+ Hits 17417 21913 +4496
- Misses 26380 31811 +5431
- Partials 1336 1407 +71
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 39.74% <ø> (+1.15%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @zhzhuang-zju @XiShanYongYe-Chang
/assign
@zhzhuang-zju can you help review this PR first, and if this PR is okey, I will continue to put forward the other three installation method just referring this.
@zhzhuang-zju can you help review this PR first, and if this PR is okey, I will continue to put forward the other three installation method just referring this.
sure, I'll go through this pr first
Generally LGTM, and you could fix the conflicts first
@RainbowMango this PR is ready~
$kubectl get secret -n karmada-system
NAME TYPE DATA AGE
etcd-cert kubernetes.io/tls 3 65m
etcd-etcd-client-cert kubernetes.io/tls 3 65m
karmada-aggregated-apiserver-cert kubernetes.io/tls 3 65m
karmada-aggregated-apiserver-config Opaque 1 65m
karmada-aggregated-apiserver-etcd-client-cert kubernetes.io/tls 3 65m
karmada-apiserver-cert kubernetes.io/tls 3 65m
karmada-apiserver-etcd-client-cert kubernetes.io/tls 3 65m
karmada-apiserver-front-proxy-client-cert kubernetes.io/tls 3 65m
karmada-apiserver-service-account-key-pair Opaque 2 65m
karmada-controller-manager-config Opaque 1 65m
karmada-descheduler-config Opaque 1 65m
karmada-descheduler-scheduler-estimator-client-cert kubernetes.io/tls 3 65m
karmada-interpreter-webhook-example-cert kubernetes.io/tls 3 65m
karmada-interpreter-webhook-example-config Opaque 1 65m
karmada-metrics-adapter-cert kubernetes.io/tls 3 65m
karmada-metrics-adapter-config Opaque 1 65m
karmada-scheduler-config Opaque 1 65m
karmada-scheduler-scheduler-estimator-client-cert kubernetes.io/tls 3 65m
karmada-search-cert kubernetes.io/tls 3 65m
karmada-search-config Opaque 1 65m
karmada-search-etcd-client-cert kubernetes.io/tls 3 65m
karmada-webhook-cert kubernetes.io/tls 3 65m
karmada-webhook-config Opaque 1 65m
kube-controller-manager-ca-cert kubernetes.io/tls 2 65m
kube-controller-manager-config Opaque 1 65m
kube-controller-manager-service-account-key-pair Opaque 2 65m
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment