karmada icon indicating copy to clipboard operation
karmada copied to clipboard

feat: scheduler add a metrics that the number of scheduling no cluste…

Open guozheng-shen opened this issue 1 year ago • 4 comments

…r fit

What type of PR is this? /kind feature

What this PR does / why we need it: Add a metric, records the number of scheduling no cluster fit.

Which issue(s) this PR fixes: NONE

Special notes for your reviewer: NONE

Does this PR introduce a user-facing change?: NONE


guozheng-shen avatar Aug 23 '24 03:08 guozheng-shen

/ok-to-test

liangyuanpeng avatar Aug 23 '24 03:08 liangyuanpeng

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.58%. Comparing base (bcf68fa) to head (100cec8). Report is 83 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
+ Coverage   30.12%   31.58%   +1.45%     
==========================================
  Files         632      643      +11     
  Lines       43936    44439     +503     
==========================================
+ Hits        13236    14036     +800     
+ Misses      29742    29373     -369     
- Partials      958     1030      +72     
Flag Coverage Δ
unittests 31.58% <100.00%> (+1.45%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 23 '24 03:08 codecov-commenter

/retest

zhzhuang-zju avatar Aug 23 '24 06:08 zhzhuang-zju

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 30 '24 03:08 karmada-bot