karmada
karmada copied to clipboard
karmada-io
retry on conflict when update cluster object in member cluster
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
retry on conflict when update cluster object in member cluster
refer to https://github.com/karmada-io/karmada/issues/5136#issuecomment-2296038607
Which issue(s) this PR fixes:
Fixes part of #5136
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
Project coverage is 30.11%. Comparing base (
bcf68fa) to head (d31d814).
| Files | Patch % | Lines |
|---|---|---|
| pkg/controllers/execution/execution_controller.go | 0.00% | 13 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5411 +/- ##
==========================================
- Coverage 30.12% 30.11% -0.01%
==========================================
Files 632 632
Lines 43936 43939 +3
==========================================
- Hits 13236 13234 -2
- Misses 29742 29746 +4
- Partials 958 959 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 30.11% <0.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/close
since the flaking test job #5136 haven't been occurred for some time, this PR temporarily closed.
@chaosi-zju: Closed this PR.
In response to this:
/close
since the flaking test job haven't been occurred for some time, this PR temporarily closed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.