karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Automated cherry pick of #5227: fix error of when cluster status condition update

Open XiShanYongYe-Chang opened this issue 1 year ago • 2 comments

Cherry pick of #5227 on release-1.10. #5227: fix error of when cluster status condition update For details on the cherry pick process, see the cherry pick requests page.

karmada-controller-manager: fix the error of cluster status old condition update will overwrite the newest condition

XiShanYongYe-Chang avatar Aug 19 '24 12:08 XiShanYongYe-Chang

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.29%. Comparing base (cc82274) to head (aeeb2f1).

Files Patch % Lines
...kg/controllers/status/cluster_status_controller.go 67.56% 10 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10    #5401   +/-   ##
=============================================
  Coverage         53.29%   53.29%           
=============================================
  Files               253      253           
  Lines             20576    20597   +21     
=============================================
+ Hits              10966    10978   +12     
- Misses             8883     8891    +8     
- Partials            727      728    +1     
Flag Coverage Δ
unittests 53.29% <67.56%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 19 '24 12:08 codecov-commenter

/cc @RainbowMango

XiShanYongYe-Chang avatar Sep 02 '24 07:09 XiShanYongYe-Chang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 02 '24 07:09 karmada-bot