skip cleanup when the poliyMarks changed

[zhzhuang-zju]

What type of PR is this? /kind bug

What this PR does / why we need it: Refer to #5307, there is a chance that poliy marks be lost when deleting the old pp/cpp and binding a new one. When performing a clean up of marks on rb/crb, we can compare the value of the label policyv1alpha1.ClusterPropagationPolicyPermanentIDLabel/policyv1alpha1.PolicyPermanentIDLabel on the cb/crb with the policyId value of the deleted CPP/PP. If they are not the same, it indicates that the rb/crb has already claimed to a new CPP/PP, and there is no need to clean up the label/annotation.

Which issue(s) this PR fixes: Fixes #5307

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Fixed an issue that poliyMarks might be lost when deleting the old pp/cpp and binding a new one

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.90%. Comparing base (11d5c97) to head (08026dc).

Files with missing lines	Patch %	Lines
pkg/detector/detector.go	0.00%	23 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5319      +/-   ##
==========================================
- Coverage   35.91%   35.90%   -0.01%     
==========================================
  Files         648      648              
  Lines       45064    45079      +15     
==========================================
+ Hits        16185    16187       +2     
- Misses      27634    27646      +12     
- Partials     1245     1246       +1     

Flag	Coverage Δ
unittests	35.90% <17.85%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[zhzhuang-zju]

cc @whitewindmills @XiShanYongYe-Chang

[whitewindmills]

/assign

[whitewindmills]

let @XiShanYongYe-Chang make the final decision. /assign @XiShanYongYe-Chang

[XiShanYongYe-Chang]

Thanks~ /lgtm

[zhzhuang-zju]

cc @RainbowMango

[XiShanYongYe-Chang]

Hi @whitewindmills can we merge this pr?

[whitewindmills]

yes

[XiShanYongYe-Chang]

It's ready to merge. Ask @RainbowMango to help make a check again. /assign @RainbowMango

[RainbowMango]

Does this need to be included in the coming patch release? #5373

[zhzhuang-zju]

Does this need to be included in the coming patch release? #5373

In terms of the frequency and severity of the issue, it's not very urgent. However, if needed, I can cherry-pick it to the corresponding release branch as soon as possible.

[zhzhuang-zju]

kindly ping @RainbowMango

[zhzhuang-zju]

kindly ping @RainbowMango

[zhzhuang-zju]

/hold util #5563 merged

[RainbowMango]

/hold util #5563 merged

Whis this PR should wait for #5563?

[zhzhuang-zju]

in #5563, I have extracted some common methods, which will affect this PR.

[zhzhuang-zju]

/hold cancel

[zhzhuang-zju]

#5563 has been merged, so this PR can now proceed

cc @whitewindmills @RainbowMango @XiShanYongYe-Chang

[RainbowMango]

OK. I will take a look.

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment