karmada
karmada copied to clipboard
docs: add proposal of karmadactl init support config file
What type of PR is this? /kind feature
What this PR does / why we need it: karmadactl supports configuration file installation and deployment Which issue(s) this PR fixes: Parts of #3464 & #4086
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 35.19%. Comparing base (
b4b6d69) to head (07803e4). Report is 340 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5277 +/- ##
==========================================
+ Coverage 28.38% 35.19% +6.81%
==========================================
Files 632 645 +13
Lines 43801 44869 +1068
==========================================
+ Hits 12432 15791 +3359
+ Misses 30464 27847 -2617
- Partials 905 1231 +326
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 35.19% <ø> (+6.81%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/assign @liangyuanpeng @zhzhuang-zju
Thanks you for opening it! I will check it later!
I have completed the implementation code section and updated the reviewer section at the beginning of the document. Professor, could you please check it when you have time?
/retest
@tiansuo114: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test /retest
/retest
May need help😭😭, in my own project's github action, these tests passed correctly, but when I commit, these tests become failed, what should I do to fix these problems @liangyuanpeng
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/alpine/manifests/sha256:0a4eaa0eecf5f8c050e5bba433f58c052be7587ee8af3e8b3910ef9ab5fbe9f5: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
This is not releated with this PR, have some pull rate limit from dockerhub (: , just run command /retest to rerun github workflow.
/ok-to-test /retest
BTW, this is a proposal PR, have not change code, so you don’t need to worry about CI because there is no document-related CI
BTW, this is a proposal PR, have not change code, so you don’t need to worry about CI because there is no document-related CIBTW,这是一个提案 PR,没有更改代码,所以你不需要担心 CI,因为没有文档相关的 CI
Ok,thanks!
/kind design
thanks, cc @XiShanYongYe-Chang for another help~
Thanks a lot, LGTM
Did we share this proposal at a community meeting?
If not, I think we can share that, for me, the proposal is clear enough and complete. See if anyone else wants to know and communicate.
Thanks a lot, LGTM
Did we share this proposal at a community meeting?
If not, I think we can share that, for me, the proposal is clear enough and complete. See if anyone else wants to know and communicate.
This proposal was shared at the Karmada meeting on August 13, 2024. I tried to find the related recording link, but it seems that it hasn't been uploaded on YouTube or Bilibili.
This proposal was shared at the Karmada meeting on August 13, 2024. I tried to find the related recording link, but it seems that it hasn't been uploaded on YouTube or Bilibili.
Thanks for the reminder. The video should not have been uploaded.
/lgtm /assign @RainbowMango
/retest
I have already modified this document according to the discussion requirements from the meeting. When you have time, please kindly review it. @liangyuanpeng @RainbowMango
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment