karmada
karmada copied to clipboard
karmada-io
feat: add average replicas assign proposal
What type of PR is this?
/kind feature /kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes: Fixes part of #5159
Special notes for your reviewer: @whitewindmills
Does this PR introduce a user-facing change?:
NONE
Other related issues: #4085
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.
Project coverage is 34.22%. Comparing base (
ef7d528) to head (68134e6).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../scheduler/core/spreadconstraint/group_clusters.go | 98.24% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5225 +/- ##
==========================================
+ Coverage 34.15% 34.22% +0.06%
==========================================
Files 643 643
Lines 44503 44551 +48
==========================================
+ Hits 15201 15248 +47
- Misses 28145 28146 +1
Partials 1157 1157
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 34.22% <98.24%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
invite these people to help with the review. /cc @RainbowMango @XiShanYongYe-Chang @chaunceyjiang @chaosi-zju @zhzhuang-zju
@whitewindmills yeah, thanks, I have received your comments and will make some changes.
@ipsum-0320: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
i have update the proposal, everyone is welcome to give me some feedback. /cc @whitewindmills @warjiang @RainbowMango @XiShanYongYe-Chang @chaunceyjiang @chaosi-zju @zhzhuang-zju
@ipsum-0320: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@RainbowMango @chaunceyjiang @warjiang still need your review. do you have any comment?
@RainbowMango @chaunceyjiang @warjiang @XiShanYongYe-Chang Does anyone have any questions? 😁
LGTM
We are about to release a major version (v1.11) soon (by the end of this month), and it seems that this feature will not make it into this version. We can start to quickly advance this feature in early September.
Hi @RainbowMango @whitewindmills @chaunceyjiang can we get on with this mission?
I'm ok with it, and seems that it looks good to @XiShanYongYe-Chang. ping @RainbowMango @chaunceyjiang
Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from chaunceyjiang. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment