karmada
karmada copied to clipboard
Only update krew index for latest stable version.
What type of PR is this?
/kind cleanup What this PR does / why we need it:
Only update krew index for latest stable version. Avoid sending noisy PRs and in the future,we don't need some PR anymore like:
- https://github.com/karmada-io/karmada/pull/4767
/cc @RainbowMango @zhzhuang-zju
Which issue(s) this PR fixes:
Ref https://github.com/karmada-io/karmada/issues/4703 Fixes #
Special notes for your reviewer:
Tested on my fork repo:
- https://github.com/liangyuanpeng/karmada/actions/runs/9987870100/job/27603262187 (release v1.10.2,running the step
Update krew index) - https://github.com/liangyuanpeng/karmada/actions/runs/9987694858 (release v1.99.3, skip the step
Update krew indexdue to karmada latest stable version is v1.10.2 and not v1.99.3 )
Does this PR introduce a user-facing change?:
NONE
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 31.47%. Comparing base (
a61d36a) to head (31177dd). Report is 30 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5224 +/- ##
==========================================
+ Coverage 31.14% 31.47% +0.33%
==========================================
Files 640 643 +3
Lines 44417 44436 +19
==========================================
+ Hits 13833 13987 +154
+ Misses 29583 29423 -160
- Partials 1001 1026 +25
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 31.47% <ø> (+0.33%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@liangyuanpeng What a coincidence, we must have been on the same wavelength! Thanks for your job, and review is ongoing~
ping @zhzhuang-zju for review :)
/assign
/lgtm cc @RainbowMango
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~.github/workflows/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment