karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[Proposal] Multi-Template Partitioning & Scheduler Extensibility

Open Vacant2333 opened this issue 1 year ago • 6 comments

What type of PR is this? /kind feature

Which issue(s) this PR fixes: From: https://github.com/karmada-io/karmada/issues/4919

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Vacant2333 avatar Jul 18 '24 05:07 Vacant2333

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jul 18 '24 05:07 karmada-bot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.86%. Comparing base (a87ec2a) to head (79e374d). Report is 596 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5218       +/-   ##
===========================================
+ Coverage   28.23%   40.86%   +12.62%     
===========================================
  Files         632      651       +19     
  Lines       43723    55259    +11536     
===========================================
+ Hits        12345    22579    +10234     
- Misses      30473    31239      +766     
- Partials      905     1441      +536     
Flag Coverage Δ
unittests 40.86% <ø> (+12.62%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 18 '24 05:07 codecov-commenter

cc @RainbowMango @XiShanYongYe-Chang It's a great feature for AI workloads scheduling, please take a look.

Monokaix avatar Sep 10 '24 07:09 Monokaix

@whitewindmills Please also give some advice.

Monokaix avatar Sep 10 '24 07:09 Monokaix

/retest

XiShanYongYe-Chang avatar Sep 10 '24 07:09 XiShanYongYe-Chang

/assign

whitewindmills avatar Sep 11 '24 01:09 whitewindmills