karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Switch openapi-gen from k8s.io/code-generator to k8s.io/kube-openapi

Open RainbowMango opened this issue 1 year ago • 3 comments
trafficstars

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The openapi-gen has been removed from k8s.io/code-generator by https://github.com/kubernetes/kubernetes/pull/123529 because it is redundant with the one in k8s.io/kube-openapi.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: We are going to bump Kubernetes dependencies to v1.30, this PR solves one of the blockers.

Does this PR introduce a user-facing change?:

NONE

RainbowMango avatar Jun 29 '24 10:06 RainbowMango

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.21%. Comparing base (c0c5569) to head (7eba226).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
- Coverage   28.22%   28.21%   -0.01%     
==========================================
  Files         632      632              
  Lines       43556    43556              
==========================================
- Hits        12293    12290       -3     
- Misses      30367    30369       +2     
- Partials      896      897       +1     
Flag Coverage Δ
unittests 28.21% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 29 '24 10:06 codecov-commenter

/assign @chaunceyjiang

RainbowMango avatar Jul 01 '24 01:07 RainbowMango

ping @chaunceyjiang

RainbowMango avatar Jul 03 '24 01:07 RainbowMango

/assign

chaunceyjiang avatar Jul 03 '24 02:07 chaunceyjiang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jul 04 '24 02:07 karmada-bot