karmada
karmada copied to clipboard
docs(proposal): add docs for using cascading deletion
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes: part of https://github.com/karmada-io/karmada/issues/4709
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 34.85%. Comparing base (
721107d) to head (fb99665). Report is 8 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
- Coverage 34.87% 34.85% -0.03%
==========================================
Files 645 645
Lines 44833 44861 +28
==========================================
- Hits 15637 15635 -2
- Misses 27991 28021 +30
Partials 1205 1205
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 34.85% <ø> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/assign
/assign @RainbowMango
Made some modifications and additions based on the comments. cc @RainbowMango @chaosi-zju
Made some modifications and additions based on the comments.
I see, what do the author @CharlesQQ thinik of https://github.com/karmada-io/karmada/pull/5101#discussion_r1739589723?
I'm now more tend to Extended by Annotation & Extend the fields of Work
I'm now more tend to
Extended by Annotation & Extend the fields of Work
You can think through the expansion of solution 1.
Solution 4 not only extends work. For the current proposal, it is a combination of two solutions, which I think is a bit redundant.
I see, what do the author @CharlesQQ thinik of https://github.com/karmada-io/karmada/pull/5101#discussion_r1739589723?
Extended by Annotation or Extend the fields of Work Choose one, I'm more tend to solution 1.
I see, what do the author @CharlesQQ thinik of #5101 (comment)?
Extended by Annotation or Extend the fields of Work Choose one, I'm more tend to solution 1.
got it, solution 1(+1)
cc @RainbowMango Help take a review again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment