karmada
karmada copied to clipboard
karmada-io
Define top level Permission for dockerhub-latest-chart.yml (latest chart to Dockerhub) work flow
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: Part of #5048
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
master@5e35497). Learn more about missing BASE report. Report is 30 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5082 +/- ##
=========================================
Coverage ? 28.20%
=========================================
Files ? 632
Lines ? 43571
Branches ? 0
=========================================
Hits ? 12289
Misses ? 30384
Partials ? 898
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 28.20% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liangyuanpeng
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~.github/workflows/OWNERS~~ [liangyuanpeng]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This PR have two commit, and https://github.com/karmada-io/karmada/pull/5082/commits/39a667ed5fa0199e115d023c50138ed45005d2fe is open at https://github.com/karmada-io/karmada/pull/5081, so it mistakenly caused PR https://github.com/karmada-io/karmada/pull/5081 to be merged as well when this PR is merged.
But the Files Changed only one file: .github/workflows/dockerhub-latest-chart.yml, this is the reason i approve it. somewhat strange.
PR https://github.com/karmada-io/karmada/pull/5081#discussion_r1662375978 still have some comment, @aditya7302 could you open a new PR for it? Thanks.