karmada
karmada copied to clipboard
karmada-io
additional print columns for CRDs: `ResourceInterpreterCustomization`…
… ClusterPropagationPolicy and PropagationPolicy
What type of PR is this?
/kind feature
What this PR does / why we need it: currently:
NAME AGE
retain-configmap 43d
retain-crd 63d
retain-cronjob 46d
retain-daemonset 46d
retain-deployment 46d
retain-mutatingwebhookconfiguration 63d
retain-pvc-annotations 52d
retain-secret 63d
retain-statefulset 46d
retain-validatingwebhookconfiguration 63d
vs.
NAME TARGET-API-VERSION TARGET-KIND
retain-configmap v1 ConfigMap
retain-crd apiextensions.k8s.io/v1 CustomResourceDefinition
retain-cronjob batch/v1 CronJob
retain-daemonset apps/v1 DaemonSet
retain-deployment apps/v1 Deployment
retain-mutatingwebhookconfiguration admissionregistration.k8s.io/v1 MutatingWebhookConfiguration
retain-pv-annotations v1 PersistentVolume
retain-pvc-annotations v1 PersistentVolumeClaim
retain-secret v1 Secret
retain-statefulset apps/v1 StatefulSet
retain-validatingwebhookconfiguration admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
`ResourceInterpreterCustomization`: Added two additional printer columns, TARGET-API-VERSION and TARGET-KIND, to represent the target resource type, these columns will be displayed in the output of kubectl get.
`PropagationPolicy`/`ClusterPropagationPolicy`: Added two additional printer columns, `Conflict-Resolution` and `Priority`, to represent the conflict resolution strategy and priority, these columns will be displayed in the output of kubectl get.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.20%. Comparing base (
8e54677) to head (cb77fdc).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5077 +/- ##
==========================================
- Coverage 28.21% 28.20% -0.02%
==========================================
Files 632 632
Lines 43571 43571
==========================================
- Hits 12293 12288 -5
- Misses 30382 30385 +3
- Partials 896 898 +2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 28.20% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~charts/OWNERS~~ [RainbowMango]
- ~~pkg/apis/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
