karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Define top level Permission for ci-schedule workflow

Open aditya7302 opened this issue 1 year ago • 6 comments
trafficstars

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: Part of #5048

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

aditya7302 avatar Jun 20 '24 08:06 aditya7302

Here is the link of the CI Schedule Workflow(ci-schedule.yml) run with modified permissions : https://github.com/aditya7302/karmada/actions/runs/9614970779

aditya7302 avatar Jun 21 '24 18:06 aditya7302

Here is the link of the CI Schedule Workflow(ci-schedule.yml) run with modified permissions : https://github.com/aditya7302/karmada/actions/runs/9614970779

@aditya7302 refer to https://github.com/aditya7302/karmada/actions/runs/9614970779/workflow, there seems be no restriction on the permissions of ci

zhzhuang-zju avatar Jun 25 '24 01:06 zhzhuang-zju

@zhzhuang-zju I am sorry It was mistake I didn't notice I will provide you with another link of the local run with permissions added.

aditya7302 avatar Jun 25 '24 09:06 aditya7302

@zhzhuang-zju here is the updated link of the workflow run with added permissions : https://github.com/aditya7302/karmada/actions/runs/9660518622/workflow

aditya7302 avatar Jun 25 '24 12:06 aditya7302

/lgtm cc @RainbowMango

zhzhuang-zju avatar Jun 25 '24 12:06 zhzhuang-zju

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@0bc96a2). Learn more about missing BASE report. Report is 51 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5069   +/-   ##
=========================================
  Coverage          ?   28.21%           
=========================================
  Files             ?      632           
  Lines             ?    43568           
  Branches          ?        0           
=========================================
  Hits              ?    12291           
  Misses            ?    30380           
  Partials          ?      897           
Flag Coverage Δ
unittests 28.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 03 '24 11:07 codecov-commenter

thanks /lgtm /approve

zhzhuang-zju avatar Jul 08 '24 08:07 zhzhuang-zju

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhzhuang-zju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jul 08 '24 08:07 karmada-bot