karmada
karmada copied to clipboard
Define top level Permission for ci-schedule-compatibility workflow
What type of PR is this? /kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: Part of #5048
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
@aditya7302 goog job~ Since this ci is executed periodically and is not running this time, have you tried to see if you can run this workflow properly with modified permissions?
@zhzhuang-zju I am trying to run this workflow on my local to test it but I couldn't figure it out.
@zhzhuang-zju I am trying to run this workflow on my local to test it but I couldn't figure it out.
You can post the link to your local test.
Here is the link of the APIServer compatibility workflow(ci-schedule-compatibility.yaml) run with modified permissions : https://github.com/aditya7302/karmada/actions/runs/9611101767
/assign @zhzhuang-zju
~~/lgtm~~ cc @RainbowMango
kindly ping @aditya7302
Helped rebase and addressed the comments. Please take another look. @zhzhuang-zju
thanks~ /lgtm
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.39%. Comparing base (
4124ba8) to head (284b9de). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5068 +/- ##
==========================================
+ Coverage 28.38% 28.39% +0.01%
==========================================
Files 632 632
Lines 43798 43798
==========================================
+ Hits 12431 12436 +5
+ Misses 30462 30459 -3
+ Partials 905 903 -2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 28.39% <ø> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~.github/workflows/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment