karmada
karmada copied to clipboard
karmada-io
Align federated CloneSet's observedGeneration semantics with its native
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: Part of https://github.com/karmada-io/karmada/issues/4870, https://github.com/karmada-io/karmada/issues/5021
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
`karmada-controller-manager`: Mark `.status.observedGeneration` of CloneSet with `.metadata.generation` only when all members' statuses are algined with its resource template generation.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.22%. Comparing base (
25f9fdd) to head (f2ad6e5). Report is 4 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5057 +/- ##
==========================================
- Coverage 28.22% 28.22% -0.01%
==========================================
Files 632 632
Lines 43553 43553
==========================================
- Hits 12293 12291 -2
- Misses 30364 30366 +2
Partials 896 896
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 28.22% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Maybe we can update these testdata files in another pr.
It would be best if we could add this in the same PR. Other PRs can also follow this template to facilitate testing.
Maybe we can update these testdata files in another pr.
It would be best if we could add this in the same PR. Other PRs can also follow this template to facilitate testing.
done. /cc @XiShanYongYe-Chang @yike21
Hi @veophi, would you mind changing your commit user to English? It might be a more common setting.
Hi @veophi, would you mind changing your commit user to English? It might be a more common setting.
ok
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/resourceinterpreter/default/thirdparty/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
