karmada icon indicating copy to clipboard operation
karmada copied to clipboard

[WIP]Proposal of rollout interperter mechanism

Open veophi opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind design

What this PR does / why we need it: Provide a Native experience for workload rollout in karmada like single k8s cluster.

Which issue(s) this PR fixes: Part of #5021

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


veophi avatar Jun 17 '24 09:06 veophi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jun 17 '24 09:06 karmada-bot

/cc @RainbowMango @XiShanYongYe-Chang @yike21

veophi avatar Jun 17 '24 09:06 veophi

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 31.70%. Comparing base (9351b76) to head (8521ec5). :warning: Report is 1397 commits behind head on master. :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5056      +/-   ##
==========================================
- Coverage   31.72%   31.70%   -0.03%     
==========================================
  Files         643      643              
  Lines       44432    44432              
==========================================
- Hits        14094    14085       -9     
- Misses      29308    29315       +7     
- Partials     1030     1032       +2     
Flag Coverage Δ
unittests 31.70% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 17 '24 09:06 codecov-commenter

/kind design

veophi avatar Jun 19 '24 02:06 veophi

proposal updated. /cc @XiShanYongYe-Chang @RainbowMango @yike21

veophi avatar Jul 15 '24 04:07 veophi

/retest

XiShanYongYe-Chang avatar Jul 16 '24 02:07 XiShanYongYe-Chang