karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Remove pp/cpp name length limit

Open XiShanYongYe-Chang opened this issue 1 year ago • 11 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

In the previous release, the names of PP and CPP are not allowed to exceed 63 characters. Now, we remove this limit.

Which issue(s) this PR fixes: Fix #4711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-webhook: Remove the limit of 63 name lengths with PropagationPolicy/ClusterPropagationPolicy resource.

XiShanYongYe-Chang avatar Jun 07 '24 08:06 XiShanYongYe-Chang

Test report: image

XiShanYongYe-Chang avatar Jun 07 '24 08:06 XiShanYongYe-Chang

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.39%. Comparing base (e7cb133) to head (911cc44).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
- Coverage   29.40%   29.39%   -0.01%     
==========================================
  Files         632      632              
  Lines       43835    43831       -4     
==========================================
- Hits        12890    12886       -4     
+ Misses      30004    30003       -1     
- Partials      941      942       +1     
Flag Coverage Δ
unittests 29.39% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 07 '24 09:06 codecov-commenter

If this is the last task, changing part of to fix would be better

zhzhuang-zju avatar Jun 12 '24 06:06 zhzhuang-zju

/cc @whitewindmills @chaunceyjiang @RainbowMango

XiShanYongYe-Chang avatar Jun 17 '24 02:06 XiShanYongYe-Chang

/retest

XiShanYongYe-Chang avatar Jul 27 '24 06:07 XiShanYongYe-Chang

/cc @chaunceyjiang

XiShanYongYe-Chang avatar Jul 27 '24 09:07 XiShanYongYe-Chang

/cc @liangyuanpeng

XiShanYongYe-Chang avatar Jul 30 '24 08:07 XiShanYongYe-Chang

/assign @RainbowMango

XiShanYongYe-Chang avatar Aug 02 '24 01:08 XiShanYongYe-Chang

Hi @chaunceyjiang can you help take a review? /assign @chaunceyjiang

XiShanYongYe-Chang avatar Aug 09 '24 08:08 XiShanYongYe-Chang

cc @RainbowMango Can we bring this into this version?

XiShanYongYe-Chang avatar Aug 31 '24 01:08 XiShanYongYe-Chang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Aug 31 '24 03:08 karmada-bot